----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2421/#review2696 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java <https://reviews.apache.org/r/2421/#comment6080> we should keep this - it's useful when debugging. unfort QP is generated so we can't add toString there. thoughts? src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java <https://reviews.apache.org/r/2421/#comment6081> this removal is problematic 1) the test caller is probably fine - it's overriding the setting 2) however Leader.java is using syncLimit, not initLimit. this may indicate a bug in the existing code? Ben/Flavio/Henry might know for sure. - Patrick On 2011-10-18 08:46:17, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2421/ > ----------------------------------------------------------- > > (Updated 2011-10-18 08:46:17) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-1234. > https://issues.apache.org/jira/browse/ZOOKEEPER-1234 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java > c518792 > > Diff: https://reviews.apache.org/r/2421/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
