[
https://issues.apache.org/jira/browse/ZOOKEEPER-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131408#comment-13131408
]
Gunnar Wagenknecht commented on ZOOKEEPER-1172:
-----------------------------------------------
Some feedback on that patch (note, I'm not a ZK committer).
* I don't like {{ZooConstructorParams}}. I'd prefer just adding a new
constructor to ZooKeeper. The requested builder pattern can be implemented on
top of that, i.e. a {{ZooKeeperBuilder}} that just invokes that appropriate
{{ZooKeeper}} constructor when done.
* Removing a public method in a public class (eg., {{ConnectStringParser}}) is
a breaking API change (if that class is considered API). BTW, adding new
constructors or methods to classes is no breaking change and doable for a
{{x.y+1}} release.
> Support for custom org.apache.zookeeper.client.HostProvider implementation.
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1172
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1172
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Reporter: César Álvarez Núñez
> Assignee: César Álvarez Núñez
> Attachments: ZOOKEEPER-1172.patch, ZOOKEEPER-1172.patch,
> ZOOKEEPER-1172.patch
>
>
> The interface org.apache.zookeeper.client.HostProvider exist but it is
> hardcoded to org.apache.zookeeper.client.StaticHostProvider at Zookeeper
> constructor.
> Now it could be replaced by any other implementation just by calling the new
> Zookeeper constructor methods which accept a HostProvider as paramater.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
