[
https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132589#comment-13132589
]
Hudson commented on ZOOKEEPER-1221:
-----------------------------------
Integrated in ZooKeeper-trunk #1339 (See
[https://builds.apache.org/job/ZooKeeper-trunk/1339/])
ZOOKEEPER-1221. Provide accessors for Request.{hdr|txn} (Thomas Koch via
phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186967
Files :
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Observer.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
> Provide accessors for Request.{hdr|txn}
> ---------------------------------------
>
> Key: ZOOKEEPER-1221
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1221
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1221.patch, ZOOKEEPER-1221.patch,
> ZOOKEEPER-1221.patch
>
>
> I'm working on a larger patch that makes the Request class immutable. To see,
> where the hdr and txn fields are modified, it helped to introduce accessor
> methods. The JVM should happily inline the method calls so no performance
> overhead should be expected.
> There's a minor, unrelated change included: ToBeAppliedRequestProcessor had a
> reference to the toBeApplied list of the Leader. So it was hard to find all
> places, where this list was actually modified. The patch gives instead the
> leader instance to the toBeAppliedRequestProcessor and the processor then
> accesses leader.toBeApplied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
