[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132613#comment-13132613
 ] 

[email protected] commented on BOOKKEEPER-84:
---------------------------------------------------------



bq.  On 2011-10-21 11:58:39, fpj wrote:
bq.  > 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java,
 line 47
bq.  > <https://reviews.apache.org/r/2403/diff/1/?file=50707#file50707line47>
bq.  >
bq.  >     I guess there is no easy way to make sure that we update this value 
when we change the format, right? Basically we need to remember to update it.

Yes


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2403/#review2739
-----------------------------------------------------------


On 2011-10-17 16:44:00, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2403/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-17 16:44:00)
bq.  
bq.  
bq.  Review request for bookkeeper, fpj and Benjamin Reed.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  There's no zk metadata versioning, which means that reading clients may 
misinterpret the data saved in ZK.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-84.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-84
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
 4452643 
bq.    
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestLedgerMetadata.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2403/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Add versioning for ZK metadata
> ------------------------------
>
>                 Key: BOOKKEEPER-84
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-84
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: BOOKKEEPER-84.diff
>
>
> There's no zk metadata versioning, which means that reading clients may 
> misinterpret the data saved in ZK. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to