[
https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135203#comment-13135203
]
Hadoop QA commented on ZOOKEEPER-1198:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500702/ZOOKEEPER-1198.1da5509_providerregistry_instance.patch
against trunk revision 1188523.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 34 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 47 javac compiler warnings (more
than the trunk's current 5 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/671//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/671//console
This message is automatically generated.
> Refactorings and Cleanups
> -------------------------
>
> Key: ZOOKEEPER-1198
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1198
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1198.03a1133.patch,
> ZOOKEEPER-1198.03a1133.patch,
> ZOOKEEPER-1198.1da5509_providerregistry_instance.patch,
> ZOOKEEPER-1198.4d184bb.patch, ZOOKEEPER-1198.52d121f.patch,
> ZOOKEEPER-1198.b23ad46.patch, ZOOKEEPER-1198.b23ad46.patch,
> ZOOKEEPER-1198.ceff47c.patch, ZOOKEEPER-1198.patch, ZOOKEEPER-1198.patch,
> ZOOKEEPER-1198.patch, ZOOKEEPER-1198.patch
>
>
> Umbrella issue for refactorings. I'll post individual refactoring steps as
> sub-issues. I'll also use this umbrella issue to submit previews of the full
> refactoring for testing by Jenkins or to ReviewBoard.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
