[
https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135223#comment-13135223
]
[email protected] commented on ZOOKEEPER-1199:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2015/
-----------------------------------------------------------
(Updated 2011-10-25 16:51:47.887909)
Review request for zookeeper.
Changes
-------
centralized the logic to deserialize requests in PrepRequestProcessor and
FinalRequestProcessor
Summary
-------
There are four places in the ZK code, that mapped OpCodes to string
representations. One of them wasn't used anymore, two others represented the
same mapping and the last one provided four letter representations. As you can
see in the definition of the OpCode enum, there were strings missing for some
newer added OpCodes. You might want to say, which strings I should put in?
I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java.
There's a switch checking for a write operation which does not include multi,
start- and stopsession. What is intended there?
This addresses bug ZOOKEEPER-1199.
https://issues.apache.org/jira/browse/ZOOKEEPER-1199
Diffs (updated)
-----
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/TxnLogSource.java
809c455
src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 9216751
src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d
src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d
src/java/main/org/apache/zookeeper/Op.java 3c3db2e
src/java/main/org/apache/zookeeper/OpResult.java 514318f
src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20
src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e
src/java/main/org/apache/zookeeper/server/DataTree.java 757a572
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 336827a
src/java/main/org/apache/zookeeper/server/LogFormatter.java 9be3fe3
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e44c65e
src/java/main/org/apache/zookeeper/server/Request.java c6a2249
src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b
src/java/main/org/apache/zookeeper/server/TraceFormatter.java 60d1cc7
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 2842803
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
938cf19
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 2f77e9d
src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
a1c8ce2
src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
27bf496
src/java/main/org/apache/zookeeper/server/quorum/Learner.java a97a543
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 2d0714f
src/java/main/org/apache/zookeeper/server/quorum/LearnerSyncRequest.java
bfbc9a8
src/java/main/org/apache/zookeeper/server/quorum/Observer.java 8e77ac8
src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
e94414f
src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
82d1468
src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4
src/java/test/org/apache/zookeeper/common/OpCodeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
38a3c57
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java a134210
Diff: https://reviews.apache.org/r/2015/diff
Testing
-------
Thanks,
Thomas
> Make OpCode an enum
> -------------------
>
> Key: ZOOKEEPER-1199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch,
> ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch,
> ZOOKEEPER-1199.patch
>
>
> ZooDefs.OpCode is an interface with integer constants. Changing this to an
> enum provides safety. See "Item 30: Use enums instead of int constants" in
> Effective Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
