I think mockito should be useful here. Our code needs to be a little cleaner to be able to test these with "real" unit tests :).
thanks mahadev On Tue, Oct 25, 2011 at 10:14 AM, Patrick Hunt <[email protected]> wrote: > Do we have a test that exercises this code path? Any commit we should > really include something that verifies the change. > > On Tue, Oct 25, 2011 at 10:12 AM, Mahadev Konar <[email protected]> > wrote: >> Thomas, >> Any chance, you could make the change just on 3.4 branch without the >> Enum changes and others? >> >> thanks >> mahadev >> >> On Tue, Oct 25, 2011 at 10:09 AM, Thomas Koch <[email protected]> wrote: >>> Ted Dunning: >>>> I would love to. My travel schedule just now is pretty heinous so I don't >>>> know when I will get to it. >>> This is how I (hopefully) fixed this: >>> https://github.com/thkoch2001/zookeeper/blob/proposed_patches/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java#L525 >>> >>> However I've several major changes made before that: >>> - enum for OpCode >>> - a class Request.Meta that holds all request meta-data: zxid, cxid, time, >>> type, owner, authinfo >>> - request lost all setXYZ methods except setException to move towards an >>> immutable request >>> >>> Regards, >>> >>> Thomas Koch, http://www.koch.ro >>> >> >
