[
https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135835#comment-13135835
]
[email protected] commented on BOOKKEEPER-89:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2543/
-----------------------------------------------------------
(Updated 2011-10-26 09:49:18.492814)
Review request for bookkeeper.
Changes
-------
Addressed comments. Removed passwd->key change. Added BookKeeperAdmin and moved
BookKeeperTools back to tools package.
Summary
-------
Changes are as follows.
BookKeeper#createLedger, parameter is named passwd, "Key" used in LedgerHandle
api
BookKeeper#getBookieClient shouldn't be public
BookKeeper#createComplete shouldn't be public
BookKeeper#openComplete shouldn't be public
BookKeeper#deleteComplete shouldn't be public
BookKeeper#halt could be changed to close(), should throw a BKException
LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be
private
LedgerHandle#getLedgerMetadata shouldn't be public
LedgerHandle#getDigestManager shouldn't be public
LedgerHandle#getDistributionSchedule shouldn't be public
LedgerHandle#writeLedgerConfig shouldn't be public
LedgerHandle#addEntry should return void, errors should go in an Exception
LedgerHandle#readComplete should not be public
LedgerHandle#addComplete should not be public
LedgerHandle#readLastConfirmedCompelte should not be public
LedgerHandle#closeComplete should not be public
ASyncCallback#RecoverCallback shouldn't be public
This addresses bug BOOKKEEPER-89.
https://issues.apache.org/jira/browse/BOOKKEEPER-89
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java
6421460
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
6af43ae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java
d4af3fa
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java
78aaa15
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
959df73
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MacDigestManager.java
1131652
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java
94e444c
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java
dfc63d7
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java
PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
224c796
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
82483f3
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java
56331ef
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieRecoveryTest.java
f933ba1
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerCacheTest.java
3a78507
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookkeeperBenchmark.java
a934985
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
726341d
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java
b918d97
pom.xml 2392db5
Diff: https://reviews.apache.org/r/2543/diff
Testing
-------
Thanks,
Ivan
> Bookkeeper API changes for initial Bookkeeper release
> -----------------------------------------------------
>
> Key: BOOKKEEPER-89
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-89.diff, BOOKKEEPER-89.diff,
> BOOKKEEPER-89.diff
>
>
> Changes are as follows.
> BookKeeper#createLedger, parameter is named passwd, "Key" used in
> LedgerHandle api
> BookKeeper#getBookieClient shouldn't be public
> BookKeeper#createComplete shouldn't be public
> BookKeeper#openComplete shouldn't be public
> BookKeeper#deleteComplete shouldn't be public
> BookKeeper#halt could be changed to close(), should throw a BKException
> LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be
> private
> LedgerHandle#getLedgerMetadata shouldn't be public
> LedgerHandle#getDigestManager shouldn't be public
> LedgerHandle#getDistributionSchedule shouldn't be public
> LedgerHandle#writeLedgerConfig shouldn't be public
> LedgerHandle#addEntry should return void, errors should go in an Exception
> LedgerHandle#readComplete should not be public
> LedgerHandle#addComplete should not be public
> LedgerHandle#readLastConfirmedCompelte should not be public
> LedgerHandle#closeComplete should not be public
> ASyncCallback#RecoverCallback shouldn't be public
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
