[
https://issues.apache.org/jira/browse/ZOOKEEPER-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1259:
-----------------------------------
Attachment: ZOOKEEPER-1259.patch
The method SerializeUtils.deserializeTxn() did not have a switch case for the
check txn. Since I only put txn types from this switch in the map, I forgot the
check txn.
The failing cpp test did not have a counterpart in a java test, so I added a
java test now.
Only thing is, that SerializeUtils.deserializeTxn() will not fail on a checktxn
after this patch as it would have done before. But that seems to be a good
thing?
> central mapping from type to txn record class
> ---------------------------------------------
>
> Key: ZOOKEEPER-1259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1259
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1259.patch, ZOOKEEPER-1259.patch,
> ZOOKEEPER-1259.patch
>
>
> There are two places where large switch statements do nothing else to get the
> correct Record class accorging to a txn type. Provided a static map in
> SerializeUtils from type to Class<? extends Record> and a method to retrieve
> a new txn Record instance for a type.
> Code size reduced by 28 lines.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
