[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Koch updated ZOOKEEPER-1266:
-----------------------------------

    Attachment: ZOOKEEPER-1266.patch
    
> "request.getHdr() != null" and "isQuorum" are identical
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-1266
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1266
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>         Attachments: ZOOKEEPER-1266.patch
>
>
> FinalRequestProcessor has this code block:
> {code:java}
>             if (request.getHdr() != null) {
>                ... SNIP ...
>             }
>             // do not add non quorum packets to the queue.
>             if (request.isQuorum()) {
>                 zks.getZKDatabase().addCommittedProposal(request);
>             }
> {code}
> Both conditions are equivalent so the two if blocks could actually be merged 
> to one block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to