[
https://issues.apache.org/jira/browse/ZOOKEEPER-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138522#comment-13138522
]
Hadoop QA commented on ZOOKEEPER-978:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501263/ZOOKEEPER-978.patch
against trunk revision 1190358.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/724//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/724//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/724//console
This message is automatically generated.
> ZookeeperServer does not close zk database on shutdwon
> ------------------------------------------------------
>
> Key: ZOOKEEPER-978
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-978
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Sergei Bobovich
> Assignee: Thomas Koch
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-978.patch, ZOOKEEPER-978.patch
>
>
> ZookeeperServer does not close zk database on shutdown leaving log files
> open. Not sure if this is an intention, but looks like a possible bug to me.
> Database is getting closed only from QuorumPeer class.
> Hit it when executing regression tests on windows: failed to delete log files
> from cleanup.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
