[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141572#comment-13141572
 ] 

Mahadev konar commented on ZOOKEEPER-1257:
------------------------------------------

Looked through the code, the rename does not change any compatibility story. We 
can change it anytime we want. Not really a blocker for 3.4.
                
> Rename MultiTransactionRecord to MultiRequest
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-1257
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1257
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Critical
>
> Understanding the code behind multi operations doesn't get any easier when 
> the code violates naming consistency.
> All other Request classes are called xxxRequest, only for multi its 
> xxxTransactionRecord! Also "Transaction" is wrong, because there is the 
> concepts of transactions that are transmitted between quorum peers or 
> committed to disc. MultiTransactionRecord however is a _Request_ from a 
> client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to