[ https://issues.apache.org/jira/browse/ZOOKEEPER-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143010#comment-13143010 ]
Hadoop QA commented on ZOOKEEPER-1284: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12502121/ZOOKEEPER-1284.patch against trunk revision 1196819. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/772//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/772//console This message is automatically generated. > Cleanup minor PrepRequestProcessor issues > ----------------------------------------- > > Key: ZOOKEEPER-1284 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1284 > Project: ZooKeeper > Issue Type: Sub-task > Reporter: Thomas Koch > Assignee: Thomas Koch > Priority: Minor > Attachments: ZOOKEEPER-1284.patch > > > Instead of having if statements in every switch case in pRequest2Txn, it is > possible to have only one if statement before the switch case in pRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira