[
https://issues.apache.org/jira/browse/ZOOKEEPER-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144492#comment-13144492
]
Alexander Shraer commented on ZOOKEEPER-1270:
---------------------------------------------
I think that ZK-1194 risk is very low. It modifies 2 lines of code in
Leader.java to make sure that the leader is in connectingFollowers
(electingFollowers) before returning from getEpochToPropose (waitForEpochAck).
It includes 2 tests for these two changes.
According to my understanding, ZK-1194 patch can replace all changes to Leader
and LearnerHandler that appear in the patches above for ZK-1270. Specifically
with ZK-1194 in it is not necessary to explicitly check that NEWLEADER message
got into the outstandingProposals, and to wait for this condition in
LeaderHandler.
I'm not sure what was the purpose of the changes to the other files in ZK-1270
but I'm pretty sure ZK-1194 addresses the same issue as the changes to Leader
and LearnerHandler made here. Also - ZK-1194 handles another possible race
condition not addressed in ZK-1270.
> testEarlyLeaderAbandonment failing intermittently, quorum formed, no serving.
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1270
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1270
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Junqueira
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1270.patch, ZOOKEEPER-1270.patch,
> ZOOKEEPER-1270_br34.patch, ZOOKEEPER-1270tests.patch,
> ZOOKEEPER-1270tests2.patch, testEarlyLeaderAbandonment.txt.gz,
> testEarlyLeaderAbandonment2.txt.gz, testEarlyLeaderAbandonment3.txt.gz,
> testEarlyLeaderAbandonment4.txt.gz
>
>
> Looks pretty serious - quorum is formed but no clients can attach. Will
> attach logs momentarily.
> This test was introduced in the following commit (all three jira commit at
> once):
> ZOOKEEPER-335. zookeeper servers should commit the new leader txn to their
> logs.
> ZOOKEEPER-1081. modify leader/follower code to correctly deal with new leader
> ZOOKEEPER-1082. modify leader election to correctly take into account current
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
