+1. looks good. one issue i found, which is i'm not sure if it is an issue or not due to my ignorance of maven, is that i had to specify the packaging when installing the jar file into my local repository:
mvn install:install-file -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar -Dpackaging=jar -DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom if i change zookeeper-3.4.0-test.pom to set the packaging type to jar rather than pom i don't need the -Dpackaging flag. i'm not sure if that is how it is supposed to be. (and even if it is a bug, it is not a release blocker.) ben On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[email protected]> wrote: > +1, ran unit tests plus some manual tests with three machines. > > -Flavio > > On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote: > >> +1. Verified the sig and checksums. Checked RAT (ok with the exception >> Mahadev listed). All the tests (incl c) are passing for me. Also ran >> with quorum sizes of 3,4,7,9 testing server failure/restart and that >> all worked. Also verified against 3.3.3 version of client (both java >> and C) and that passed as well. >> >> Looks good to me! >> >> Patrick >> >> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <[email protected]> >> wrote: >>> >>> FYI, >>> Pat pointed this out. There are some warnings with rat which are >>> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300 >>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is. >>> >>> thanks >>> mahadev >>> >>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <[email protected]> >>> wrote: >>>> >>>> Minor update, had to change the bits since I had forgotten to fix >>>> ZOOKEEPER-1299. >>>> >>>> The bits are now uptodate. Please review and vote. >>>> >>>> thanks >>>> mahadev >>>> >>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <[email protected]> >>>> wrote: >>>>> >>>>> Sorry I meant, >>>>> >>>>> ** Tuesday, Nov 22 **. >>>>> >>>>> thanks >>>>> mahadev >>>>> >>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar >>>>> <[email protected]> wrote: >>>>>> >>>>>> Hi all, >>>>>> I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and >>>>>> ZOOKEEPER-1208 that were fixed last week. >>>>>> >>>>>> *** Please download, test and VOTE before the >>>>>> *** vote closes 5pm PT on Saturday, Nov22*** >>>>>> >>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/ >>>>>> >>>>>> Should we release this? >>>>>> >>>>>> >>>>>> thanks >>>>>> mahadev >>>>>> >>>>> >>>> >>> > > flavio > junqueira > > research scientist > > [email protected] > direct +34 93-183-8828 > > avinguda diagonal 177, 8th floor, barcelona, 08018, es > phone (408) 349 3300 fax (408) 349 3301 > >
