[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165532#comment-13165532
 ] 

Hadoop QA commented on ZOOKEEPER-1269:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501375/ZOOKEEPER-1269.patch
  against trunk revision 1208979.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/815//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/815//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/815//console

This message is automatically generated.
                
> Multi deserialization issues
> ----------------------------
>
>                 Key: ZOOKEEPER-1269
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1269
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1269.patch
>
>
> From the mailing list:
> FileTxnSnapLog.restore contains a code block handling a NODEEXISTS failure 
> during deserialization. The problem is explained there in a code comment. The 
> code block however is only executed for a CREATE txn, not for a multiTxn 
> containing a CREATE.
> Even if the mentioned code block would also be executed for multi 
> transactions, it needs adaption for multi transactions. What, if after the 
> first failed transaction in a multi txn during deserialization, there would 
> be subsequent transactions in the same multi that would also have failed?
> We don't know, since the first failed transaction hides the information about 
> the remaining transactions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to