[
https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165534#comment-13165534
]
Hadoop QA commented on ZOOKEEPER-1262:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502217/patch.txt
against trunk revision 1208979.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/816//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/816//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/816//console
This message is automatically generated.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0, 3.4.1
>
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here:
> http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't
> deal with the problem of create() succeeding but the server crashing before
> the result is returned. As written, if the server crashes before the result
> is returned the client can never know what sequential node was created for
> it. The way to deal with this is to embed the session ID in the node name.
> The Lock implementation in the ZK distro does this. But, the documentation
> will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
