----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2208/#review3914 -----------------------------------------------------------
a good cleanup, some comments before we can commit it. /src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java <https://reviews.apache.org/r/2208/#comment8794> cleanup this typo (2 returns) /src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java <https://reviews.apache.org/r/2208/#comment8793> let's call this getRegisteredBeans() /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/2208/#comment8795> Add back the try/catch protection. This was necessary in some cases (I can't remember why off the top of my head though). /src/java/test/org/apache/zookeeper/test/QuorumUtilTest.java <https://reviews.apache.org/r/2208/#comment8796> license header is missing. add the std boilerplate found on any other java file in the project. /src/java/test/org/apache/zookeeper/test/QuorumUtilTest.java <https://reviews.apache.org/r/2208/#comment8798> add a comment to the class describing what this set of tests is for /src/java/test/org/apache/zookeeper/test/QuorumUtilTest.java <https://reviews.apache.org/r/2208/#comment8797> no tabs, reformat with spaces only. (you'll probably need to cleanup some of your other changes at the same time) /src/java/test/org/apache/zookeeper/test/QuorumUtilTest.java <https://reviews.apache.org/r/2208/#comment8799> it's fine to ref a jira here, however there should also be some details on what this test is doing. (short summary esp as the test itself is pretty clear) - Patrick On 2011-10-05 11:59:30, César Álvarez Núñez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2208/ > ----------------------------------------------------------- > > (Updated 2011-10-05 11:59:30) > > > Review request for zookeeper. > > > Summary > ------- > > See https://issues.apache.org/jira/browse/ZOOKEEPER-1214 > > > This addresses bug ZOOKEEPER-1214. > https://issues.apache.org/jira/browse/ZOOKEEPER-1214 > > > Diffs > ----- > > /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1179165 > /src/java/test/org/apache/zookeeper/test/QuorumUtilTest.java PRE-CREATION > /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1179166 > /src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java 1169669 > > Diff: https://reviews.apache.org/r/2208/diff > > > Testing > ------- > > - > > > Thanks, > > César > >
