[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174248#comment-13174248
 ] 

Camille Fournier commented on ZOOKEEPER-1333:
---------------------------------------------

Ah ok. Yeah, so if we put the create check in, we won't get that nonode 
exception if the multi fails on that, would be the only potential issue with 
this fix that I can see.
                
> NPE in FileTxnSnapLog when restarting a cluster
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-1333
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1333
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Andrew McNair
>            Assignee: Patrick Hunt
>            Priority: Blocker
>             Fix For: 3.4.2
>
>         Attachments: ZOOKEEPER-1333.patch, ZOOKEEPER-1333.patch, 
> test_case.diff, test_case.diff
>
>
> I think a NPE was created in the fix for 
> https://issues.apache.org/jira/browse/ZOOKEEPER-1269
> Looking in DataTree.processTxn(TxnHeader header, Record txn) it seems likely 
> that if rc.err != Code.OK then rc.path will be null. 
> I'm currently working on a minimal test case for the bug, I'll attach it to 
> this issue when it's ready.
> java.lang.NullPointerException
>       at 
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:203)
>       at 
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:150)
>       at 
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
>       at 
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:418)
>       at 
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:410)
>       at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:151)
>       at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
>       at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to