[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174267#comment-13174267
 ] 

Patrick Hunt commented on ZOOKEEPER-126:
----------------------------------------

@oliver I think the issue is that limiting the wait time would change the 
semantics of the close call. Not something we typically do in a minor release.

However I could see us adding a close(timeout) method which provides this 
capability. (probably would have been better to start with that, hindsight is 
always 20/20)

@daniel I think you should open a jira on that NPE issue you mentioned (if you 
haven't already - although I don't see it "linked" to this jira)

                
> zookeeper client close operation may block indefinitely
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-126
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-126
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-126.patch, ZOOKEEPER-126.patch
>
>
> Moving the hang issue from ZOOKEEPER-63 to here. See 63 for background and 
> potential patch (patch_ZOOKEEPER-63.patch).
> specifically (from James): 
> "I'm thinking the close() method should not wait() forever on the disconnect 
> packet, just a closeTimeout length - say a few seconds. Afterall blocking and 
> forcing a reconnect just to redeliver the disconnect packet seems a bit silly 
> - when the server has to deal with clients which just have their sockets fail 
> anyway"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to