[
https://issues.apache.org/jira/browse/ZOOKEEPER-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated ZOOKEEPER-1230:
---------------------------------------
Attachment: ZOOKEEPER-1230.patch
Refactor append() moving out logStream initialization, making fast return and
adding checksum for byte[]
mashallTxnEntry() code is duplicated in quorum leader
> Cleanup FileTxnLog
> ------------------
>
> Key: ZOOKEEPER-1230
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1230
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Attachments: ZOOKEEPER-1230.patch
>
>
> - remove Interface TxnLog. The discussion on the mailing list (subject: "Get
> rid of unnecessary Interfaces") didn't give a definite No...?
> - make things private where possible
> - does preAllocSize need to be static and therefor global?
> - the append method has one big if statement from begin to end. make this a
> fast return
> - new private method to initialize a new logStream if logSTream == null
> - move the check for a faulty transaction in the method
> o.a.z.s.persistence.Util.marshallTxnEntry
> - mashallTxnEntry is only ever used from the append method of FileTxnLog.
> However I've seen the same code somewhere else...
> - new private method that returns a checksum for a given bytebuffer and length
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
