----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3364/#review4184 -----------------------------------------------------------
As part of this patch the programmer guide needs to be updated to detail how this feature works. In particular it should detail the semantics of watch removal, any "gotchas" to watch out for, etc... - Patrick On 2012-01-04 09:41:43, Daniel Gómez Ferro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3364/ > ----------------------------------------------------------- > > (Updated 2012-01-04 09:41:43) > > > Review request for zookeeper and Benjamin Reed. > > > Summary > ------- > > Added APIs to remove watches that are not needed anymore. If the removal > completes successfully it is guaranteed that the watcher won't be notified. > > With the current semantics if two clients remove watches on a znode at the > same time the watch is triggered, one could remove it successfully while the > other could receive the notification first. > > > This addresses bug ZOOKEEPER-442. > https://issues.apache.org/jira/browse/ZOOKEEPER-442 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40 > src/java/main/org/apache/zookeeper/KeeperException.java 7c10d2c > src/java/main/org/apache/zookeeper/Watcher.java 36c7b5b > src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20 > src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0 > src/java/main/org/apache/zookeeper/server/DataTree.java 757a572 > src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 336827a > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1a80d74 > src/java/main/org/apache/zookeeper/server/Request.java c6a2249 > src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 > src/java/main/org/apache/zookeeper/server/ZKDatabase.java 2842803 > src/java/test/org/apache/zookeeper/test/RemoveWatchesTest.java PRE-CREATION > src/zookeeper.jute d24e145 > > Diff: https://reviews.apache.org/r/3364/diff > > > Testing > ------- > > Added unit test that checks client side semantics. > > > Thanks, > > Daniel > >
