[
https://issues.apache.org/jira/browse/ZOOKEEPER-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180177#comment-13180177
]
Hadoop QA commented on ZOOKEEPER-1351:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509480/ZOOKEEPER-1351.patch
against trunk revision 1227000.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/877//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/877//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/877//console
This message is automatically generated.
> invalid test verification in MultiTransactionTest
> -------------------------------------------------
>
> Key: ZOOKEEPER-1351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1351
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.4.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.3
>
> Attachments: ZOOKEEPER-1351.patch, ZOOKEEPER-1351_br34.patch
>
>
> tests such as
> org.apache.zookeeper.test.MultiTransactionTest.testWatchesTriggered() are
> incorrect. Two issues I see
> 1) zk.sync is async, there is no guarantee that the watcher will be called
> subsequent to sync returning
> {noformat}
> zk.sync("/", null, null);
> assertTrue(watcher.triggered); /// incorrect assumption
> {noformat}
> The callback needs to be implemented, only once the callback is called can we
> verify the trigger.
> 2) trigger is not declared as volatile, even though it will be set in the
> context of a different thread (eventthread)
> See
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-solaris/91/testReport/junit/org.apache.zookeeper.test/MultiTransactionTest/testWatchesTriggered/
> for an example of a false positive failure
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.zookeeper.test.MultiTransactionTest.testWatchesTriggered(MultiTransactionTest.java:236)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
