2012/1/5 César Álvarez Núñez <[email protected]>: > Hi all, > > I would like to: > > - Modify the usage of slf4j api on zk code since calls to > org.slf4j.Logger methods should use parameters instead of "string > concatenation" (http://www.slf4j.org/faq.html#logging_performance)
The original patch updated to use slf4j, but not everything was updated to use the new features. I think that would be a great goal though. Some of my pending patches make improvements here. > - Update to latest SLF4J version. > > But I have several questions: > > 1. There is no need to apply ZOOKEEPER-850 to zookeeper-trunk since it > is already done. Right? 850 patch was applied, but the jira was later reopened, pointing to this issue as a blocker: https://issues.apache.org/jira/browse/ZOOKEEPER-1010 > 2. It should be managed as a new jira or as an evolution of > ZOOKEEPER-850? 850 is done, I'd suggest you open a new jira. Likely 1010 has to be addressed regardless. > 3. Since there will be many affected files, should be open a new branch? > > Since I'm a beginner contributor any suggestion/feedback is welcome. Only committers can commit to branches so that's not really possible. We could open the branch for you but we'd still have to review/commit. I'd suggest you do the work in stages, a section of files at a time. Basically you want to minimize the review overhead so that committers can easily review/commit. Otw you're going to have problems wrt conflicts as other patches go in while your patch takes a long time to review (during which more conflicts occur, and so on). Create an umbrella jira wrt making this upgrade. Then create sub-tasks with associated jiras as you sweep through. I'd also suggest you remove the old "trace" facility as part of this work. (use std tracing provided by slf4j). I don't believe anyone uses the old trace masking. Patrick
