[
https://issues.apache.org/jira/browse/ZOOKEEPER-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180828#comment-13180828
]
Hadoop QA commented on ZOOKEEPER-1352:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509602/ZOOKEEPER-1352_trunk.patch
against trunk revision 1227000.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/880//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/880//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/880//console
This message is automatically generated.
> server.InvalidSnapshotTest is using connection timeouts that are too short
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1352
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1352
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.3.4
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.5, 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-1352_br33.patch, ZOOKEEPER-1352_br34.patch,
> ZOOKEEPER-1352_trunk.patch
>
>
> InvalidSnapshotTest is using connection timeouts that are too short, see this
> false failure:
> https://builds.apache.org/job/ZooKeeper_branch33_solaris/65/testReport/junit/org.apache.zookeeper.server/InvalidSnapshotTest/testInvalidSnapshot/
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode
> = ConnectionLoss for /invalidsnap-0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:643)
> at
> org.apache.zookeeper.server.InvalidSnapshotTest.testInvalidSnapshot(InvalidSnapshotTest.java:71)
> {noformat}
> Also in looking at the test itself it could use some cleanup (reuse features
> from ClientBase test utils)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
