[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182358#comment-13182358
 ] 

kishore gopalakrishna commented on ZOOKEEPER-1183:
--------------------------------------------------

The patch I have provided adds the ability to print the data if the transaction 
modifies the data along with the path that change. You can check out the patch 
and free to either use it, modify it or start from scratch.( It does not handle 
multi transaction)

The requirements I added were from the experience I had when we used this 
patched LogFormatter to provide additional data needed to debug 
https://issues.apache.org/jira/browse/ZOOKEEPER-1208.

I dont think its ambitious, its based on whether you want to say its not a 
bug(I guess thats what you said in that 1208) because the user cant provide 
additional/relevant data or have the ability to ask user to run a command(which 
would have been a better thing) and give its output and you can reason about it.

We had to spend quite some time to actually provide the relevant data needed 
for the ticket to actually find the issue and be solved. Don't know if its the 
right thing to expect every one to understand the transaction log to provide 
the relevant data. 





                
> Enhance LogFormatter to output additional detail from transaction log
> ---------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1183
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1183
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.0
>            Reporter: kishore gopalakrishna
>            Assignee: kishore gopalakrishna
>            Priority: Minor
>         Attachments: ZOOKEEPER-1183.patch
>
>
> Current LogFormatter prints the following information
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> 8/15/11 1:55:36 PM PDT session 0x131cf1a236f0014 cxid 0x0 zxid 0xf01 
> createSession
> 8/15/11 1:55:57 PM PDT session 0x131cf1a236f0000 cxid 0x55f zxid 0xf02 setData
> 8/15/11 1:56:00 PM PDT session 0x131cf1a236f0015 cxid 0x0 zxid 0xf03 
> createSession
> ...
> ..
> 8/15/11 2:00:33 PM PDT session 0x131cf1a236f001c cxid 0x36 zxid 0xf6b setData
> 8/15/11 2:00:33 PM PDT session 0x131cf1a236f0021 cxid 0xa1 zxid 0xf6c create
> 8/15/11 2:00:33 PM PDT session 0x131cf1a236f001b cxid 0x3e zxid 0xf6d setData
> 8/15/11 2:00:33 PM PDT session 0x131cf1a236f001e cxid 0x3e zxid 0xf6e setData
> 8/15/11 2:00:33 PM PDT session 0x131cf1a236f001d cxid 0x41 zxid 0xf6f setData
> Though this is good information, it does not provide additional information 
> like 
> createSession: which ip created the session and its time out
> set|get|delete: the path and data 
> create: path created and createmode along with data
> We can add additional parameter -detail and provide detailed output of the 
> transaction.
> Outputting data is slightly tricky since we cant print data without 
> understanding the format. We need not print this for now. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to