> On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, > > lines 160-182 > > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line160> > > > > I had an idea when reviewing another jira recently. That fits with this > > and the new pkging really well. (sorry, that was after I mentioned about > > adding to the admin guide). > > > > I now think we should add man pages for executables such as scripts. I > > think having a reference from the guide is not nearly as useful. Also, now > > that we have the pkgs we can include the man pages there. It's a much > > better solution than the guide for stuff like this. > > > > Would you mind moving this into a man page? Seems like mainly > > reformatting.
Will do. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, > > line 161 > > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line161> > > > > "a configuration file..." Will make correction. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, > > line 166 > > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line166> > > > > should we give the example with sudo? or just user level. sudo works better to be on the safe side for writing to /var. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, > > line 180 > > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line180> > > > > I'm not sure what this means "Forward to start ..." > > > > ? This means skip to next section. I will revise the wording. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh, > > line 47 > > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line47> > > > > running twice would overwrite the original, is there any way to store > > multiple versions? backup old copy by timestamp? > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh, > > line 67 > > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line67> > > > > does this mean the datadir must exist prior to running the script? > > (would be good to document) I will mkdir -p to make sure directory exists. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh, > > lines 69-70 > > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line69> > > > > shouldn't we allow the quorum and election ports to be specified? I will add those options. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh, > > lines 153-154 > > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line153> > > > > this is wrong. we don't want to have autopurge on by default. it's too > > new of a feature. I would recommend to have this feature on by default to reduce admin tasks. Long running server has tendency to run out of disk space without this option turn on, which I encountered several times. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh, > > line 164 > > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line164> > > > > same q here re backup. will add timestamp. > On 2011-12-22 23:52:26, Patrick Hunt wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh, > > lines 176-177 > > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line176> > > > > I'm not sure I get this, what's the expectation, that the user will run > > this on each of the servers, with exactly the same parameters? I see that > > the myid is based on this assumption, that seems like it's going to cause > > alot of problems. With zkconf I generated all the environments (for all > > servers) then allow the user to copy them to the right place. That limits > > this type of issue. This is designed to run locally on the servers to integrate with configuration management tools like puppet or chef to run. I think we can keep setupQuorum function as it is. For running one time setup script and distribute by rsync. myid file can be setup as a separate step because the content of the file is different per server. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3116/#review4092 ----------------------------------------------------------- On 2011-12-09 20:45:09, Eric Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3116/ > ----------------------------------------------------------- > > (Updated 2011-12-09 20:45:09) > > > Review request for zookeeper, Patrick Hunt and Mahadev Konar. > > > Summary > ------- > > Add a setup script for ZooKeeper > > > This addresses bug ZOOKEEPER-1296. > https://issues.apache.org/jira/browse/ZOOKEEPER-1296 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/zookeeper/trunk/build.xml 1200013 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml > 1200013 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh > PRE-CREATION > > Diff: https://reviews.apache.org/r/3116/diff > > > Testing > ------- > > > Thanks, > > Eric > >
