[
https://issues.apache.org/jira/browse/ZOOKEEPER-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185212#comment-13185212
]
[email protected] commented on ZOOKEEPER-1296:
----------------------------------------------------------
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml,
lines 160-182
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line160>
bq. >
bq. > I had an idea when reviewing another jira recently. That fits with
this and the new pkging really well. (sorry, that was after I mentioned about
adding to the admin guide).
bq. >
bq. > I now think we should add man pages for executables such as scripts.
I think having a reference from the guide is not nearly as useful. Also, now
that we have the pkgs we can include the man pages there. It's a much better
solution than the guide for stuff like this.
bq. >
bq. > Would you mind moving this into a man page? Seems like mainly
reformatting.
Will do.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml,
line 161
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line161>
bq. >
bq. > "a configuration file..."
Will make correction.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml,
line 166
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line166>
bq. >
bq. > should we give the example with sudo? or just user level.
sudo works better to be on the safe side for writing to /var.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml,
line 180
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63710#file63710line180>
bq. >
bq. > I'm not sure what this means "Forward to start ..."
bq. >
bq. > ?
This means skip to next section. I will revise the wording.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh,
line 47
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line47>
bq. >
bq. > running twice would overwrite the original, is there any way to
store multiple versions?
backup old copy by timestamp?
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh,
line 67
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line67>
bq. >
bq. > does this mean the datadir must exist prior to running the script?
(would be good to document)
I will mkdir -p to make sure directory exists.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh,
lines 69-70
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line69>
bq. >
bq. > shouldn't we allow the quorum and election ports to be specified?
I will add those options.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh,
lines 153-154
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line153>
bq. >
bq. > this is wrong. we don't want to have autopurge on by default. it's
too new of a feature.
I would recommend to have this feature on by default to reduce admin tasks.
Long running server has tendency to run out of disk space without this option
turn on, which I encountered several times.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh,
line 164
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line164>
bq. >
bq. > same q here re backup.
will add timestamp.
bq. On 2011-12-22 23:52:26, Patrick Hunt wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh,
lines 176-177
bq. > <https://reviews.apache.org/r/3116/diff/1/?file=63711#file63711line176>
bq. >
bq. > I'm not sure I get this, what's the expectation, that the user will
run this on each of the servers, with exactly the same parameters? I see that
the myid is based on this assumption, that seems like it's going to cause alot
of problems. With zkconf I generated all the environments (for all servers)
then allow the user to copy them to the right place. That limits this type of
issue.
This is designed to run locally on the servers to integrate with configuration
management tools like puppet or chef to run. I think we can keep setupQuorum
function as it is. For running one time setup script and distribute by rsync.
myid file can be setup as a separate step because the content of the file is
different per server.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3116/#review4092
-----------------------------------------------------------
On 2011-12-09 20:45:09, Eric Yang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3116/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-09 20:45:09)
bq.
bq.
bq. Review request for zookeeper, Patrick Hunt and Mahadev Konar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add a setup script for ZooKeeper
bq.
bq.
bq. This addresses bug ZOOKEEPER-1296.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1296
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/zookeeper/trunk/build.xml 1200013
bq.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
1200013
bq.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3116/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Eric
bq.
bq.
> Add zookeeper-setup-conf.sh script
> ----------------------------------
>
> Key: ZOOKEEPER-1296
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1296
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.4.0
> Environment: Shell script
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1296-1.patch, ZOOKEEPER-1296-2.patch,
> ZOOKEEPER-1296.patch
>
>
> It would be nice to provide a setup script for zoo.cfg and zookeeper-env.sh.
> The proposed script will provide the following options:
> {noformat}
> usage: /usr/sbin/zookeeper-setup-conf.sh <parameters>
> Required parameters:
> --conf-dir Set ZooKeeper configuration directory
> --log-dir Set ZooKeeper log directory
> Optional parameters:
> --auto-purge-interval=1 Set snapshot auto purge interval
> --client-port=2181 Set client port
> --data-dir=/var/lib/zookeeper Set data directory
> --hosts=host1,host2 Set ZooKeeper qourum hostnames
> --init-limit=10 Set initial sync limit
> --java-home Set JAVA_HOME location
> --snapshot-count=3 Set snapshot retain count
> --sync-limit=5 Set sync limit
> --tick-time=2000 Set milliseconds of each tick
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
