----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3451/#review4424 -----------------------------------------------------------
The bulk of the code in this patch could be removed if zookeeper's ZKMBeanRegistry was updated to allow easy extension. Have you looked at changing the ZK code? Of course, we'd need to continue to use the code in this patch until a version of zookeeper with the change is released, but i think it would make things cleaner. bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java <https://reviews.apache.org/r/3451/#comment9935> Why is this static? - Ivan On 2012-01-11 01:04:57, Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3451/ > ----------------------------------------------------------- > > (Updated 2012-01-11 01:04:57) > > > Review request for bookkeeper. > > > Summary > ------- > > we can extends/reuses zookeeper JMX until to monitor and manage bookie server > > > This addresses bug BOOKKEEPER-95. > https://issues.apache.org/jira/browse/BOOKKEEPER-95 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanInfo.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3451/diff > > > Testing > ------- > > > Thanks, > > Sijie > >
