[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195933#comment-13195933
 ] 

Benjamin Reed commented on ZOOKEEPER-1378:
------------------------------------------

i'm not sure if this is such a good idea. if people start enabling this option 
"just to be sure", we are going to run into a dual problem of 1) less 
production experience for the DIFF code path 2) other performance problems with 
always doing a diff. the second problem can be particularly bad since diffs 
make the initial sync with the leader very fast. if you always cause a state 
transfer (aka snapshot) to happen, you will increase the network load, leader 
load, and sync time. and these increases will grow linearly with the size of 
your database. i'm a -0 on this one.
                
> Provide option to turn off sending of diffs
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1378
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1378
>             Project: ZooKeeper
>          Issue Type: Task
>            Reporter: Zhihong Yu
>             Fix For: 3.3.5, 3.4.3
>
>
> From Patrick:
> we need to have an option to turn off sending of diffs. There are a couple of 
> really strong reasons I can think of to do this:
> 1) 3.3.x is broken in a similar way, there is an upgrade problem we can't 
> solve short of having ppl first upgrade to a fixed 3.3 (3.3.5 say) and then 
> upgrading to 3.4.x. If we could turn off diff sending this would address the 
> problem.
> 2) safety valve. Say we find another new problem with diff sending in 
> 3.4/3/5. Having an option to turn it off would be useful for people as a 
> workaround until a fix is found and released.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to