[
https://issues.apache.org/jira/browse/ZOOKEEPER-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202987#comment-13202987
]
Hadoop QA commented on ZOOKEEPER-1387:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513712/ZOOKEEPER-1387.patch
against trunk revision 1240959.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/953//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/953//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/953//console
This message is automatically generated.
> Wrong epoch file created
> ------------------------
>
> Key: ZOOKEEPER-1387
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1387
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.2
> Reporter: Benjamin Busjaeger
> Priority: Minor
> Attachments: ZOOKEEPER-1387.patch
>
>
> It looks like line 443 in QuorumPeer [1] may need to change from:
> writeLongToFile(CURRENT_EPOCH_FILENAME, acceptedEpoch);
> to
> writeLongToFile(ACCEPTED_EPOCH_FILENAME, acceptedEpoch);
> I only noticed this reading the code, so I may be wrong and I don't know yet
> if/how this affects the runtime.
> [1]
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L443
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
