[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221925#comment-13221925
 ] 

Hadoop QA commented on ZOOKEEPER-271:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517001/ZOOKEEPER-271-1.patch
  against trunk revision 1296035.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 3 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/973//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/973//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/973//console

This message is automatically generated.
                
> Better command line parsing in ZookeeperMain.
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-271
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-271
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Mahadev konar
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-271-1.patch
>
>
> The command line parsing in zookeepermain is very basic.We should use some 
> kind of cli parsing (commons-cli?) or something else that is standard and 
> improve our command line parsing. This will remove the scattered code that we 
> have in zookeepermain and we will have much better command line parsing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to