[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250278#comment-13250278
 ] 

Jay Shrauner commented on ZOOKEEPER-517:
----------------------------------------

- Fixed accept() code to trap errors so the select handler loop doesn't skip 
handling any other IO requests (such as, eg, closing a socket)
- Added rate limiting to error logging. Noticed when stressing the server with 
too many connections that the server was pegging on hammering the error logs
- Reproduced issue Patrick noted and fixed closing of too many connects from 
single client so they wouldn't park in CLOSE_WAIT
                
> NIO factory fails to close connections when the number of file handles run 
> out.
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-517
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-517
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Mahadev konar
>            Assignee: Benjamin Reed
>            Priority: Critical
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-517.patch
>
>
> The code in NIO factory is such that if we fail to accept a connection due to 
> some reasons (too many file handles maybe one of them) we do not close the 
> connections that are in CLOSE_WAIT. We need to call an explicit close on 
> these sockets and then close them. One of the solutions might be to move doIO 
> before accpet so that we can still close connection even if we cannot accept 
> connections.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to