[
https://issues.apache.org/jira/browse/ZOOKEEPER-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262170#comment-13262170
]
Hadoop QA commented on ZOOKEEPER-1454:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12524354/ZOOKEEPER-1454.patch
against trunk revision 1330043.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//console
This message is automatically generated.
> Document how to run autoreconf if cppunit is installed in a non-standard
> directory
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1454
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1454
> Project: ZooKeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1454.patch
>
>
> By default, the source distribution of cppunit is installed under /usr/local.
> When you run {{autoreconf -if}}, you get an error like this:
> {code}
> $ autoreconf -if
> configure.ac:37: warning: macro `AM_PATH_CPPUNIT' not found in library
> configure.ac:37: warning: macro `AM_PATH_CPPUNIT' not found in library
> configure.ac:37: error: possibly undefined macro: AM_PATH_CPPUNIT
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> autoreconf: /usr/local/bin/autoconf failed with exit status: 1
> {code}
> This is because {{cppunit.m4}} is installed under /usr/local/share/aclocal,
> but aclocal only looks at {{/usr/share/aclocal-$VERSION}} and
> {{/usr/share/aclocal}} assuming it was configured with {{--prefix=/usr}}.
> There are 3 ways to specify additional paths.
> 1. Set {{ACLOCAL}}.
> {code}
> ACLOCAL="aclocal -I /usr/local/share/aclocal" autoreconf -if
> {code}
> 2. Set {{ACLOCAL_PATH}}.
> {code}
> ACLOCAL_PATH=/usr/local/share/aclocal autoreconf -if
> {code}
> 3. Set {{ACLOCAL_FLAGS}}.
> {code}
> ACLOCAL_FLAGS="-I /usr/local/share/aclocal" autoreconf -if
> {code}
> Apparently older versions of autoreconf don't respect ACLOCAL_PATH or
> ACLOCAL_FLAGS, so using ACLOCAL is probably the best way to fix it. I'll
> update src/c/README to document this.
> --Michi
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
