[
https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262435#comment-13262435
]
Michi Mutsuzaki commented on ZOOKEEPER-1371:
--------------------------------------------
Thanks for the patch, César! Here are my comments:
# Please update the "Logging" section of
src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml. It should note
that ZooKeeper uses slf4j and defaults to log4j binding (I'm assuming
log4j-1.2.16.jar and slf4j-log4j12-1.6.4.jar will be included in the new
release under lib/).
# Right now bin/zkServer.{sh,cmd} doesn't initialize logging properly for
developers since log4j-1.2.16.jar and slf4j-log4j12-1.6.4.jar are located under
build/test/lib/. Should we add build/test/lib/ to the classpath in
bin/zkEnv.{sh,cmd}?
# Thank you for adding unit tests for JMX!
--Michi
> Remove dependency on log4j in the source code.
> ----------------------------------------------
>
> Key: ZOOKEEPER-1371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3
> Reporter: Mahadev konar
> Assignee: César Álvarez Núñez
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1371.patch
>
>
> ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We
> should remove the dependency on log4j so that we can make logging pluggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
