[
https://issues.apache.org/jira/browse/ZOOKEEPER-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266111#comment-13266111
]
Hadoop QA commented on ZOOKEEPER-1461:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525220/ZOOKEEPER-1461.PATCH
against trunk revision 1331246.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1056//console
This message is automatically generated.
> Zookeeper C client doesn't check for NULL before dereferencing in
> prepend_string
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1461
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1461
> Project: ZooKeeper
> Issue Type: Improvement
> Components: c client
> Affects Versions: 3.3.5
> Reporter: Stephen Tyree
> Assignee: Stephen Tyree
> Fix For: 3.3.6
>
> Attachments: ZOOKEEPER-1461.PATCH
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> prepend_string, called before any checks for NULL in the c client for many
> API functions, has this line (zookeeper 3.3.5):
> if (zh->chroot == NULL)
> That means that before you check for NULL, you are dereferencing the pointer.
> This bug does not exist in the 3.4.* branch for whatever reason, but it still
> remains in the 3.3.* line. A patch which fixes it would make the line as
> follows:
> if (zh == NULL || zh->chroot == NULL)
> I would do that for you, but I don't know how to patch the 3.3.5 branch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
