[
https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272144#comment-13272144
]
Hadoop QA commented on ZOOKEEPER-1463:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525970/zookeeper-1463_1339.patch
against trunk revision 1336467.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1067//console
This message is automatically generated.
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Fix For: 3.4.4, 3.5.0
>
> Attachments: zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file,
> which is not compatible with C99. This causes problem when compiling with
> other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores
> this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
