[
https://issues.apache.org/jira/browse/ZOOKEEPER-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272333#comment-13272333
]
Hadoop QA commented on ZOOKEEPER-1448:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526341/ZOOKEEPER-1448.patch
against trunk revision 1336467.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1069//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1069//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1069//console
This message is automatically generated.
> Node+Quota creation in transaction log can crash leader startup
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1448
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1448
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.5
> Reporter: Botond Hejj
> Assignee: Botond Hejj
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1448.patch, ZOOKEEPER-1448.patch,
> ZOOKEEPER-1448.patch
>
>
> Hi,
> I've found a bug in zookeeper related to quota creation which can shutdown
> zookeeper leader on startup.
> Steps to reproduce:
> 1. create /quota_bug
> 2. setquota -n 10000 /quota_bug
> 3. stop the whole ensemble (the previous operations should be in the
> transaction log)
> 4. start all the servers
> 5. the elected leader will shutdown with an exception (Missing stat node for
> count /zookeeper/quota/quota_bug/zookeeper_
> stats)
> I've debugged a bit what happening and I found the following problem:
> On startup each server loads the last snapshot and replays the last
> transaction log. While doing this it fills up the pTrie variable of the
> DataTree with the path of the nodes which have quota.
> After the leader is elected the leader servers loads the snapshot and last
> transaction log but it doesn't clean up the pTrie variable. This means it
> still contains the "/quota_bug" path. Now when the "create /quota_bug" is
> processed from the transaction log the DataTree already thinks that the quota
> nodes ("/zookeeper/quota/quota_bug/zookeeper_limits" and
> "/zookeeper/quota/quota_bug/zookeeper_stats") are created but those node
> creation actually comes later in the transaction log. This leads to the
> missing stat node exception.
> I think clearing the pTrie should solve this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
