[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295127#comment-13295127
 ] 

Adalberto Medeiros commented on ZOOKEEPER-1236:
-----------------------------------------------

-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

This was tested for both ibm jvm and sun jvm. I think the unit tests already 
created for testing the KerberosName.java are enough here. Is there anything 
else needed?
                
> Security uses proprietary Sun APIs
> ----------------------------------
>
>                 Key: ZOOKEEPER-1236
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1236
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0, 3.4.3
>            Reporter: Patrick Hunt
>            Assignee: Eugene Koontz
>             Fix For: 3.5.0
>
>         Attachments: zookeeper-1236-v2.patch, zookeeper-1236.patch
>
>
> See HADOOP-7211 - Recent kerberos integration resulted in the same issue in 
> ZK.
> {noformat}
>     [javac] 
> /home/phunt/dev/zookeeper/src/java/main/org/apache/zookeeper/server/auth/KerberosName.java:88:
>  warning: sun.security.krb5.KrbException is Sun proprietary API and may be 
> removed in a future release
>     [javac]     } catch (KrbException ke) {
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to