[
https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404658#comment-13404658
]
Hadoop QA commented on ZOOKEEPER-1493:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534135/ZOOKEEPER-1493_3_4.patch
against trunk revision 1355657.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1118//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1118//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1118//console
This message is automatically generated.
> C Client: zookeeper_process doesn't invoke completion callback if
> zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch,
> ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if
> zookeeper_close() has been called. This was to avoid calling assert(cptr) on
> a NULL pointer, as dequeue_completion() returns NULL if the sent_requests
> queue has been cleared by free_completion() from zookeeper_close(). However,
> we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
