[ https://issues.apache.org/jira/browse/ZOOKEEPER-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411382#comment-13411382 ]
Flavio Junqueira commented on ZOOKEEPER-1453: --------------------------------------------- I'm glad it worked, Marshall. bq. there is still a potential issue with corruption from a reboot that should be addressed under this jira. In my understanding, the partial writes during syncs that Bill is referring to would be captured by the crc checks. Is this not enough? > corrupted logs may not be correctly identified by FileTxnIterator > ----------------------------------------------------------------- > > Key: ZOOKEEPER-1453 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1453 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.3.3 > Reporter: Patrick Hunt > Priority: Critical > Attachments: 10.10.5.123-withPath1489.tar.gz, 10.10.5.123.tar.gz, > 10.10.5.42-withPath1489.tar.gz, 10.10.5.42.tar.gz, > 10.10.5.44-withPath1489.tar.gz, 10.10.5.44.tar.gz > > > See ZOOKEEPER-1449 for background on this issue. The main problem is that > during server recovery > org.apache.zookeeper.server.persistence.FileTxnLog.FileTxnIterator.next() > does not indicate if the available logs are valid or not. In some cases (say > a truncated record and a single txnlog in the datadir) we will not detect > that the file is corrupt, vs reaching the end of the file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira