[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419391#comment-13419391
 ] 

Hadoop QA commented on ZOOKEEPER-1426:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12537373/ZOOKEEPER-1426-1.patch
  against trunk revision 1362660.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//console

This message is automatically generated.
                
> add version command to the zookeeper server
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1426
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts, server
>    Affects Versions: 3.3.5
>            Reporter: Patrick Hunt
>              Labels: newbie, patch
>         Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh. 
> Hadoop does this by having a special main class: 
> org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information 
> class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to