[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446227#comment-13446227
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-325:
------------------------------------------------

In this case, we may schedule many timerTasks, if there are many open ledgers 
within that grace period right?
I felt that, simple thread would be better for processing them, because there 
can be multiple ledgers got added to the pending replications list. I just 
borrowed this concept from HDFS pending replication processing :-)

{quote}
check if last ledger fragment is still open (will require a call to checker 
again).
{quote}
Yes, I have to check again. this added in my previous 
[comment|https://issues.apache.org/jira/browse/BOOKKEEPER-325?focusedCommentId=13444840&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13444840]
 as well.

{quote}
If so, then open with fencing.
In all cases, release the lock.
{quote}
I think patch doing the same, it is releasing the lock in all the cases.

If you don't mind, could you please list the comments which are expecting to 
change from this patch? :-) ( small confusions for me from above comments)

Thanks a lot,
Uma 

                
> Delay the replication of a ledger if RW found that its last fragment is in 
> underReplication.
> --------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-325
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-325
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-auto-recovery
>    Affects Versions: 4.2.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: BOOKKEEPER-325.patch
>
>
> When RW found that ledger's last fragment is in underReplication state, then 
> we should delay that ledger replication for some grace period. optimally we 
> can replicate other fragments.
> The idea is, Whenever it finds the last fragement is under replicated, It can 
> add into PendingReplication list.
> There will be a small daemon, which will check for the timeouts of this 
> ledgers. 
> Once it timed out , it will trigger the normal replication process if it is 
> not in last fragment. Otherwise, it will fence the ledger and will trigger 
> the replication nomally.
> see the discussion for more info:
> http://markmail.org/message/ruhhxxgvuqnjlu2s#query:+page:1+mid:f6ifo4sizulwiaem+state:results

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to