[
https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460909#comment-13460909
]
Hadoop QA commented on ZOOKEEPER-1376:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546108/ZOOKEEPER-1376.patch
against trunk revision 1386496.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1185//console
This message is automatically generated.
> zkServer.sh does not correctly check for $SERVER_JVMFLAGS
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3, 3.3.4
> Reporter: Patrick Hunt
> Priority: Minor
> Labels: newbie
> Fix For: 3.3.7, 3.4.5
>
> Attachments: ZOOKEEPER-1376.patch
>
>
> It will always include it even if not defined, although not much harm.
> if [ "x$SERVER_JVMFLAGS" ]
> then
> JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
> fi
> should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
