-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7283/
-----------------------------------------------------------

Review request for zookeeper.


Description
-------

This change adds support for returning a Stat object from create() node calls. 
It provides updates to both the Java API as well as the C API. To maintain 
backwards client compatibility, a new Create2Request/Response type was added 
rather than modifying the existing types. This does lead to some places where 
code is somewhat duplicated between old and new request types. I made some 
changes to help with this, but I also didn't want to destabilize the existing 
create code very much. With some refactoring better code sharing could probably 
be accomplished.

Added some new tests and also updated the CLI to support this new Create type.


This addresses bug ZOOKEEPER-1297.
    https://issues.apache.org/jira/browse/ZOOKEEPER-1297


Diffs
-----

  src/c/include/proto.h bce408e 
  src/c/include/zookeeper.h 7d1066a 
  src/c/src/cli.c 44ff9d4 
  src/c/src/zookeeper.c a705d18 
  src/c/tests/TestClient.cc ba12259 
  src/java/main/org/apache/zookeeper/AsyncCallback.java 3037723 
  src/java/main/org/apache/zookeeper/ClientCnxn.java c239328 
  src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d 
  src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d 
  src/java/main/org/apache/zookeeper/OpResult.java 45331d1 
  src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20 
  src/java/main/org/apache/zookeeper/ZooKeeper.java f58d418 
  src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 
  src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java e8f7992 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java b11db7c 
  src/java/main/org/apache/zookeeper/server/Request.java c6a2249 
  src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4 
  src/java/test/org/apache/zookeeper/test/AsyncOps.java 328a15a 
  src/java/test/org/apache/zookeeper/test/AsyncOpsTest.java 340bd73 
  src/java/test/org/apache/zookeeper/test/CreateTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 03c39a9 
  src/java/test/org/apache/zookeeper/test/SyncCallTest.java 4fb006a 
  src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java cc82c87 
  src/zookeeper.jute d24e145 

Diff: https://reviews.apache.org/r/7283/diff/


Testing
-------

All existing tests + new tests pass, validated using CLI against local zkServer


Thanks,

Lenni Kuff

Reply via email to