Yes, I'd like to use the reviewboard. I think I have time to review ZOOKEEPER-1355 this weekend.
Thanks! --Michi On Wed, Oct 10, 2012 at 2:48 PM, Alexander Shraer <[email protected]> wrote: > great! thanks guys, your help is really appreciated!! > > please use the latest ZK-107 patch as I've changed some parts of the C > implementation recently. Don't hesitate > to ask me for any clarifications about the new APIs. For reference you > can also take a look on the new Java tests in that patch, > although I think that they cover much more than necessary for the C tests. > > Michi, actually there is a related patch > (https://issues.apache.org/jira/browse/ZOOKEEPER-1355) that needs a > review. > Flavio reviewed the Java part of it, and I fixed the patch according > to his comments, and then Marshall added a C > implementation that wasn't reviewed yet. I don't feel confident enough > in the C client implementation to review it. > If you can review it, please use Marshall's latest patch on this Jira. > If you like using the reviewboard I can update it with latest code. > > Thanks, > Alex > > On Wed, Oct 10, 2012 at 2:35 PM, Michi Mutsuzaki <[email protected]> > wrote: >> I'm available as well for reviewing the code, writing test, or >> whatever is necessary to get this feature out. >> >> Thanks! >> --Michi >> >> On Wed, Oct 10, 2012 at 2:24 PM, Marshall McMullen >> <[email protected]> wrote: >>> Hey Alex, I am definitely (still) interested in helping out with this. >>> Unfortunately things have been super busy for me for the last few >>> weeks in my day job and it's required a lot of late nights and after >>> hours to finish. >>> >>> I'm wrapping that up now, so I intend to have some free time over >>> the next couple weeks where I'll be able to contribute to this very >>> worthy feature. >>> >>> --Marshall >>> >>> ---------- Forwarded message ---------- >>> From: Alexander Shraer <[email protected]> >>> Date: Wed, Oct 10, 2012 at 12:52 PM >>> Subject: C client & reconfiguration >>> To: [email protected] >>> >>> >>> Hi All, >>> >>> If you're using (or familiar with) the ZooKeeper C client and would >>> like to help out with ZooKeeper 107, we still need a couple of >>> basic C tests for it. There are currently plenty of Java client and >>> server tests, including all kinds of failure scenarios, >>> so the C client tests should really just test the basic C reconfiguration >>> API. >>> >>> Thanks, >>> Alex
