----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7603/#review12505 -----------------------------------------------------------
Ship it! lgtm - just need to update to include the license header. src/java/main/org/apache/jute/BinaryInputArchive.java <https://reviews.apache.org/r/7603/#comment26631> seems like a reasonable compromise to me. src/java/test/org/apache/zookeeper/test/BufferSizeTest.java <https://reviews.apache.org/r/7603/#comment26632> Missing the license header boilerplate. - Patrick Hunt On Oct. 15, 2012, 6:25 p.m., Skye Wanderman-Milne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7603/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 6:25 p.m.) > > > Review request for zookeeper, Patrick Hunt, Henry Robinson, and Camille > Fournier. > > > Description > ------- > > I've decided my previous patch for ZK-1513 is indeed a bad idea. This one's a > pretty janky fix but essentially a one-liner (see BinaryInputArchive.java). > > > This addresses bug ZOOKEEPER-1513. > https://issues.apache.org/jira/browse/ZOOKEEPER-1513 > > > Diffs > ----- > > build.xml 8b84073 > src/java/main/org/apache/jute/BinaryInputArchive.java 8f329eb > src/java/test/data/buffersize/create/version-2/log.1 PRE-CREATION > src/java/test/data/buffersize/create/version-2/snapshot.0 PRE-CREATION > src/java/test/data/buffersize/set/version-2/log.1 PRE-CREATION > src/java/test/data/buffersize/set/version-2/snapshot.0 PRE-CREATION > src/java/test/data/buffersize/snapshot/version-2/log.1 PRE-CREATION > src/java/test/data/buffersize/snapshot/version-2/snapshot.0 PRE-CREATION > src/java/test/data/buffersize/snapshot/version-2/snapshot.3 PRE-CREATION > src/java/test/org/apache/zookeeper/test/BufferSizeTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/7603/diff/ > > > Testing > ------- > > ant test (new junit tests test issuing creates/sets and reading large > creates/sets/znodes from disk) > > > Thanks, > > Skye Wanderman-Milne > >
