> On Oct. 25, 2012, 9:36 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 160-161 > > <https://reviews.apache.org/r/7730/diff/1/?file=179601#file179601line160> > > > > hm, maybe this is ok given the clientTunneledAuthenticationInProgress > > check. However it seems like it would be more straightforward to just > > reorder the queue, no?
It is OK (at least until something breaks it), but I've changed it to move the chosen auth packet to the front of the queue anyway. - Skye ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/#review12794 ----------------------------------------------------------- On Oct. 25, 2012, 10:51 p.m., Skye Wanderman-Milne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7730/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2012, 10:51 p.m.) > > > Review request for zookeeper, Patrick Hunt and Ted Yu. > > > Description > ------- > > see ZOOKEEPER-1560 JIRA > > > This addresses bug ZOOKEEPER-1560. > https://issues.apache.org/jira/browse/ZOOKEEPER-1560 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 70d8538 > > Diff: https://reviews.apache.org/r/7730/diff/ > > > Testing > ------- > > unit tests (including testLargeNodeData from ZOOKEEPER-1560 JIRA) > > > Thanks, > > Skye Wanderman-Milne > >
