[
https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487548#comment-13487548
]
Patrick Hunt commented on ZOOKEEPER-1474:
-----------------------------------------
This looks good, a few small comments/questions on the patch:
1) "//only works on Unix" this is confusing, I think you mean these params are
only available on unix? would be good to update the comment and move into the
top of the block (if I'm interpreting that right)
2) remove the commented out code in
src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
3) what systems and jvms have you tested this on?
4) can you verify the compilation and that your tests pass on Windows? I see
that you have a test that explicitly fails except on unix. We have users
running on windows systems.
FYI: I will add an IBM JDK specific job to jenkins when this goes in:
https://builds.apache.org//view/S-Z/view/ZooKeeper/ Notice we have windows jobs
there already.
> Cannot build Zookeeper with IBM Java: use of Sun MXBean classes
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1474
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1474
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.4.3, 3.4.4
> Reporter: Adalberto Medeiros
> Assignee: Adalberto Medeiros
> Labels: build
> Attachments: zookeeper-1474.patch, zookeeper-1474-v2.patch,
> zookeeper-1474-v3.patch
>
>
> zookeeper.server.NIOServerCnxn and zookeeper.server.NettyServerCnxn imports
> com.sun.management.UnixOperatingSystemMXBean . This OperatingSystemMXBean
> class is not implemented by IBM or open java.
> In my case, I need IBM Java so I can run zookeeper in Power ppc64 servers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
