[
https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491706#comment-13491706
]
Thawan Kooburat commented on ZOOKEEPER-1558:
--------------------------------------------
- This is minor but you can make Zab1_0Test class extends ClientBase and use
its createTmpDir() method instead of creating tmpDir manually.
- Please update comments such as //Setup a database... and //Set the last.. to
reflect what actually happen
- Can we also test that the leader take snapshot when it have quorum of
supported? Not sure if it is possible, but if we don't shutdown the leader at
the end of the test and start a follower, then we should be able to test that
code path.
> Leader should not snapshot uncommitted state
> --------------------------------------------
>
> Key: ZOOKEEPER-1558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: quorum
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch,
> ZOOKEEPER-1558.patch
>
>
> Leader currently takes a snapshot when it calls loadData in the beginning of
> the lead() method. The loaded data, however, may contain uncommitted state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
